R style columns #212
R style columns #212
Conversation
|
Mind taking a look @znicholls? I want to give @danielhuppmann a bit of a break from reviews (at least for one!). |
There was a problem hiding this comment.
Nice @gidden ! My only thought may be to have a warning if R-style columns or maybe some more assertions (assert that second is four characters long maybe?) so it's more obvious to people if they do have some weird edge case where their column starts with X and can be thrown to int but isn't meant to be a time (although typing this now that sounds like overkill).
|
Ok, can do. Errors in CI are not related, FYI. |
I guessed as much. Do you want me to split my fix from #198 out into a separate PR to see if that helps? |
Ignore that, just looked at the errors properly |
There was a problem hiding this comment.
nice feature @gidden! One suggestion to move the auxiliary function out of format_data() to make that function not even more verbose...
|
tests will fail again because our backends are down from public access.. |
|
should be good to go now |
|
once issue discussion resolved with @danielhuppmann |
Please confirm that this PR has done the following:
Description of PR
Who else has gotten very useful data from very useful colleages in that very pesky R-style data format, where year columns look like
X2015instead of just2015? Worry no more,pyamhas your back!